[webkit-reviews] review granted: [Bug 46209] WebKit2 should look for WebKit2WebProcess.exe next to WebKit.dll : [Attachment 68277] [PATCH] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 21 13:07:35 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 46209: WebKit2 should look for WebKit2WebProcess.exe next to WebKit.dll
https://bugs.webkit.org/show_bug.cgi?id=46209

Attachment 68277: [PATCH] Fix
https://bugs.webkit.org/attachment.cgi?id=68277&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68277&action=review

> WebKit2/UIProcess/Launcher/win/ProcessLauncherWin.cpp:35
> +const LPCWSTR webkitDLLName = L"WebKit_debug.dll";

Should be webKitDLLName (with a capital "K").

>> WebKit2/UIProcess/Launcher/win/ProcessLauncherWin.cpp:57
>> +	HMODULE webkitModule = GetModuleHandle(webkitDLLName);
> 
> We've been using :: to namespace quality Win32 calls lately.

We've also been using the W versions of the APIs, so:
::GetModuleHandleW(webKitDLLName);

>> WebKit2/UIProcess/Launcher/win/ProcessLauncherWin.cpp:63
>> +	if (!GetModuleFileName(webkitModule, pathStr, MAX_PATH) ||
GetLastError() != ERROR_SUCCESS)
> 
> You shouldn't need to check GetLastError and the result of the function. Just
checking the result for 0 should be enough to check for failure.
> Same comment about the ::.

_countof(pathStr) would be better than repeating MAX_PATH.


More information about the webkit-reviews mailing list