[webkit-reviews] review granted: [Bug 46179] [gtk] Move copyContextProperties outside the GraphicsContextCairo : [Attachment 68276] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 46179: [gtk] Move copyContextProperties outside the GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=46179

Attachment 68276: Patch
https://bugs.webkit.org/attachment.cgi?id=68276&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68276&action=review

Looks good! Please fix these small nits before landing:

> WebCore/GNUmakefile.am:3357
> +	WebCore/platform/graphics/cairo/CairoUtilities.cpp \
> +	WebCore/platform/graphics/cairo/CairoUtilities.h \

These should be moved under CairoPath.h to keep the source list in alphabetical
order.

> WebCore/GNUmakefile.am:3392
> +	WebCore/platform/graphics/gtk/GdkCairoUtilities.cpp \
> +	WebCore/platform/graphics/gtk/GdkCairoUtilities.h \

These should be moved under FontGtk.cpp to keep the source list in alphabetical
order.

> WebCore/platform/graphics/cairo/CairoUtilities.cpp:31
> +#include <cairo.h>
> +
> +#include <wtf/Vector.h>

Remove the empty line here.