[webkit-reviews] review denied: [Bug 45721] Add a client interface to allow V8Proxy to ask whether an extension should run on a page : [Attachment 68139] style fixes

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Matt Perry
<mpcomplete at chromium.org>'s request for review:
Bug 45721: Add a client interface to allow V8Proxy to ask whether an extension
should run on a page
https://bugs.webkit.org/show_bug.cgi?id=45721

Attachment 68139: style fixes
https://bugs.webkit.org/attachment.cgi?id=68139&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68139&action=review

> WebCore/bindings/v8/V8DOMWindowShell.cpp:344
> +	       // Ensure our extension is always allowed.

nit: Ensure our date extension is always allowed.

> WebKit/chromium/public/WebFrameClient.h:305
> +    virtual bool allowScriptExtension(WebFrame*, const WebString&
extensionName, int extensionGroup) { return true; }

should the magic extensionGroup with value 0 be defined here?

> WebKit/chromium/public/WebScriptController.h:62
> +    WEBKIT_API static void registerExtension2(v8::Extension*);

it may be easier to just call this registerExtension.  overriding based on
arguments is fine.
that way you do not need to rename registerExtension2 back to registerExtension
later.