[webkit-reviews] review granted: [Bug 46196] Add marginBefore/After/Start/End accessors to RenderBoxModelObject and subclasses : [Attachment 68253] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 21 10:05:04 PDT 2010


mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 46196: Add marginBefore/After/Start/End accessors to RenderBoxModelObject
and subclasses
https://bugs.webkit.org/show_bug.cgi?id=46196

Attachment 68253: Patch
https://bugs.webkit.org/attachment.cgi?id=68253&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=68253&action=review

> WebCore/rendering/RenderInline.h:44
> +    virtual int marginTop() const;
> +    virtual int marginBottom() const;

Any reason why these need to be public now (or, for that matter, any of the new
methods)?


More information about the webkit-reviews mailing list