[webkit-reviews] review denied: [Bug 45156] Send webkit accessibility notifications to Chromium : [Attachment 68187] Send remaining webkit notifications to Chromium

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied chris.guillory at google.com's
request for review:
Bug 45156: Send webkit accessibility notifications to Chromium
https://bugs.webkit.org/show_bug.cgi?id=45156

Attachment 68187: Send remaining webkit notifications to Chromium
https://bugs.webkit.org/attachment.cgi?id=68187&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68187&action=review

> WebCore/ChangeLog:6
> +	   https://bugs.webkit.org/show_bug.cgi?id=45156

comment should end with a period

> WebCore/accessibility/chromium/AXObjectCacheChromium.cpp:88
> +    case AXRowExpanded:

these cases should be alphabetized

> WebCore/accessibility/chromium/AXObjectCacheChromium.cpp:109
> +

this ASSERT might not be correct. for example, this is possible

<div role="group" aria-hidden="true" tabindex="0">test</div>

where the div should be ignored, but it can be focused

> WebCore/editing/chromium/SelectionControllerChromium.cpp:42
> +

seems like you don't need to access document until it's inside the if block, so
there's no need to declare out here