[webkit-reviews] review denied: [Bug 46086] Web Inspector: implement pausing on XHR : [Attachment 68249] Couple of renames.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 46086: Web Inspector: implement pausing on XHR
https://bugs.webkit.org/show_bug.cgi?id=46086

Attachment 68249: Couple of renames.
https://bugs.webkit.org/attachment.cgi?id=68249&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68249&action=review

> WebCore/inspector/InspectorController.cpp:2137
> +#if ENABLE(JAVASCRIPT_DEBUGGER)

I think you should inline willSendXHR here.

> WebCore/inspector/InspectorController.h:483
> +inline InspectorController*
InspectorController::inspectorControllerForDocument(Document* document)

Can we employ static InspectorController counter here to speed up things?

> WebCore/inspector/InspectorDebuggerAgent.h:48
> +enum DebuggerEvent {

NativeBreakpointType ?

> WebCore/inspector/InspectorDebuggerAgent.h:83
> +    void willSendXHR(const String& url);

willSendXHR does not look good as a part of debugger agent.