[webkit-reviews] review granted: [Bug 46166] Web Inspector: Elements panel does not reflect changes in the text node values. : [Attachment 68248] [PATCH] Proposed change.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 46166: Web Inspector: Elements panel does not reflect changes in the text
node values.
https://bugs.webkit.org/show_bug.cgi?id=46166

Attachment 68248: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=68248&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68248&action=review

> WebCore/dom/CharacterData.cpp:201
> +    InspectorController::characterDataModified(this);

I'd rather guard this call with #if ENABLED(INSPECTOR)

> WebCore/inspector/front-end/DOMAgent.js:391
> +	   node.textContent = textContent;

textContent doesn't seem to be defined here.