[webkit-reviews] review denied: [Bug 46179] [gtk] Move copyContextProperties outside the GraphicsContextCairo : [Attachment 68223] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 21 08:57:01 PDT 2010


Martin Robinson <mrobinson at webkit.org> has denied  review:
Bug 46179: [gtk] Move copyContextProperties outside the GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=46179

Attachment 68223: Patch
https://bugs.webkit.org/attachment.cgi?id=68223&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68223&action=review

>> WebCore/platform/graphics/gtk/CairoUtilities.cpp:32
>>  #include <gtk/gtk.h>
> 
> <wtf/Vector.h> should go under <gtk/gtk.h> per WebKit code style.
> 
> r=me with this change. We'll have to wait to land this until after the
original ContextShadow patch lands. :/

This will need to go into a platform-independent file. :/


More information about the webkit-reviews mailing list