[webkit-reviews] review granted: [Bug 46185] [WIN] Add internetHandle to WebCoreSynchronousLoader. : [Attachment 68237] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 46185: [WIN] Add internetHandle to WebCoreSynchronousLoader.
https://bugs.webkit.org/show_bug.cgi?id=46185

Attachment 68237: Patch
https://bugs.webkit.org/attachment.cgi?id=68237&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=68237&action=review

> WebCore/platform/network/win/ResourceHandleWin.cpp:87
> +static HINTERNET asynchronousInternetHandle(const String& userAgent)
> +{
> +    static HINTERNET internetHandle = 0;
> +
> +    if (!internetHandle)
> +	   internetHandle = createInternetHandle(userAgent, true);
> +
> +    return internetHandle;
> +}

You can do this more simply:

static HINTERNET internetHandle = createInternetHandle(userAgent, true);
return internetHandle;

> WebCore/platform/network/win/ResourceHandleWin.cpp:188
>      , m_response(response)
>      , m_data(data)
>  {
> +    m_internetHandle = createInternetHandle(userAgent, false);
> +}

Why not put this in the initializer list?