[webkit-reviews] review denied: [Bug 46165] Focused frame information needed in Chrome and ChromeClient : [Attachment 68192] Added a new method to Chrome and ChromeClient which is called when focused frame has changed

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Juha Savolainen
<juha.savolainen at weego.fi>'s request for review:
Bug 46165: Focused frame information needed in Chrome and ChromeClient
https://bugs.webkit.org/show_bug.cgi?id=46165

Attachment 68192: Added a new method to Chrome and ChromeClient which is called
when focused frame has changed
https://bugs.webkit.org/attachment.cgi?id=68192&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68192&action=review

> WebCore/page/ChromeClient.h:90
> +	   virtual void focusedFrameChanged() {};

I would prefer if this was pure-virtual like most of the others in this file.


Can you also explain the use case a little more about the use case for having
this information in the UIProcess. Why is it necessary to know which frame has
focus?