[webkit-reviews] review denied: [Bug 45666] [Qt] Click's count is limited to three continuous click : [Attachment 67453] Proposed patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied Ragner Magalhaes
<ragner.magalhaes at openbossa.org>'s request for review:
Bug 45666: [Qt]  Click's count is limited to three continuous click
https://bugs.webkit.org/show_bug.cgi?id=45666

Attachment 67453: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=67453&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=67453&action=review

Good patch! I like the way you took the click couting control out of
EventSender class.

A few nits, questions and requests:

1) How many consecutive clicks we support now? (triple clicking used to be the
limite, right?)
2) You're removing a bunch of methods from WebPagePrivate class, Please,
explain in our changelog why and how it is working now.

It would be great if we could make sure that, after your change, when the
routine DlbClick was suposed to be called, it clickCould would be '2'. Same for
the triple clicking routine.

Any way to assert of this case as a sanity check?

> WebKit/qt/Api/qwebpage.cpp:628
> +    Frame *focusedFrame;

Make it Frame *focusedFrame = 0;

> WebKit/qt/Api/qwebpage.cpp:672
> +    Frame *focusedFrame;

Make it Frame *focusedFrame = 0;

> WebKit/qt/ChangeLog:7
> +

Add here why you are removing the double and triple click handler routines, and
how it is working not.