[webkit-reviews] review granted: [Bug 45891] DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods : [Attachment 68107] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 21 05:41:20 PDT 2010
Jeremy Orlow <jorlow at chromium.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 45891: DeviceOrientationClient and DeviceMotionClient should have
controllerDestroyed() methods
https://bugs.webkit.org/show_bug.cgi?id=45891
Attachment 68107: Patch
https://bugs.webkit.org/attachment.cgi?id=68107&action=review
------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68107&action=review
> WebKit/mac/WebCoreSupport/WebDeviceOrientationClient.mm:65
> + delete this;
I'm not positive about this part. If you are, then I guess we can go with it.
If you aren't, maybe this should go in its own patch for someone from the mac
port to review?
More information about the webkit-reviews
mailing list