[webkit-reviews] review requested: [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text : [Attachment 68201] Single patch for fixing this bug

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 25898: [Gtk] object:text-changed events should be emitted for entries and
password text
https://bugs.webkit.org/show_bug.cgi?id=25898

Attachment 68201: Single patch for fixing this bug
https://bugs.webkit.org/attachment.cgi?id=68201&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #83)
> (In reply to comment #82)
> 
> build failed because of
> 
> 
> cc1plus: warnings being treated as errors
> /Users/abarth/git/webkit-queue/WebCore/editing/AppendNodeCommand.cpp:46:
warning: unused parameter 'textChange'

Argh! Didn't see that, sorry.

Attaching new patch fixing that smal issue (the variable should actually be
used, not hardcoded.)