[webkit-reviews] review granted: [Bug 46125] Convert table cell intrinsic padding to be logical instead of hardcoded. : [Attachment 68197] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 21 00:31:33 PDT 2010


mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 46125: Convert table cell intrinsic padding to be logical instead of
hardcoded.
https://bugs.webkit.org/show_bug.cgi?id=46125

Attachment 68197: Patch
https://bugs.webkit.org/attachment.cgi?id=68197&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=68197&action=review

> WebCore/ChangeLog:7
> +	   to before/after-based.  That way a vertical text table can have
intrinsic padding built into the left/right
> +	   direction (and this allows the base class logical padding methods on
RenderBoxModelObject to safe to use).

Missing a word here.


More information about the webkit-reviews mailing list