[webkit-reviews] review canceled: [Bug 46004] Change Clipboard to use an enum instead of isForDragging = true/false : [Attachment 68114] Patch

[bugzilla-daemon at webkit.org]

Daniel Cheng <dcheng at chromium.org> has canceled Daniel Cheng
<dcheng at chromium.org>'s request for review:
Bug 46004: Change Clipboard to use an enum instead of isForDragging =
true/false
https://bugs.webkit.org/show_bug.cgi?id=46004

Attachment 68114: Patch
https://bugs.webkit.org/attachment.cgi?id=68114&action=review

------- Additional Comments from Daniel Cheng <dcheng at chromium.org>
(In reply to comment #9)
> (From update of attachment 68114 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=68114&action=review
> 
> > WebCore/ChangeLog:8
> > +	     No new tests. (OOPS!)
> 
> This needs to be replaced with an explanation. Either:
> 1. Name the test(s),
> 2. Describe why a test isn't possible, or
> 3. Indicate that no new functionality is exposed so no new test is needed.
> 

Done.

> > WebCore/dom/Clipboard.h:96
> > +	     Clipboard(ClipboardAccessPolicy, ClipboardType clipboardType);
> 
> Parameter name "clipboardType" shouldn't be here.
> 

Done.

> > WebCore/platform/chromium/ClipboardChromium.cpp:207
> >		 // If this isn't for a drag, it's for a cut/paste event
handler.
> 
> It looks like this comment isn't needed anymore (but if you remove it, you
need to update the next comment line slightly).
> 
> > WebCore/platform/chromium/ClipboardChromium.cpp:223
> >		 // If this isn't for a drag, it's for a cut/paste event
handler.
> 
> Ditto.

Done.

> 
> > WebCore/platform/mac/ClipboardMac.h:82
> > +	 ClipboardMac(ClipboardType clipboardType, NSPasteboard *,
ClipboardAccessPolicy, Frame*);
> 
> Param name should go away.
> 

Done.

> > WebCore/platform/win/ClipboardWin.h:81
> > +	 ClipboardWin(ClipboardType clipboardType, IDataObject*,
ClipboardAccessPolicy, Frame*);
> > +	 ClipboardWin(ClipboardType clipboardType, WCDataObject*,
ClipboardAccessPolicy, Frame*);
> 
> Param name should go away.
> 

Done.

> > WebCore/platform/wx/ClipboardWx.h:68
> > +	     ClipboardWx(ClipboardAccessPolicy, ClipboardType clipboardType);
> 
> Param name should go away.

Done.