[webkit-reviews] review granted: [Bug 46153] Add Preview button and link to bug to patch review bar : [Attachment 68169] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 46153: Add Preview button and link to bug to patch review bar
https://bugs.webkit.org/show_bug.cgi?id=46153

Attachment 68169: Patch
https://bugs.webkit.org/attachment.cgi?id=68169&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68169&action=review

> BugsSite/code-review.js:257
> +    $(document.body).prepend('<div id="toolbar"><div class="actions"><button
id="preview_comments">Preview</button><button
id="post_comments">Publish</button></div><div class="message"><a
href="show_bug.cgi?id=' + bug_id + '" target="_blank">bug ' + bug_id + '</a>
<span class="commentStatus"></span> <span class="help">Double-click a line or
click or drag on line numbers to add a comment.</span></div></div>');

Thanks for writing this patch.	This should work great.  The only problem is
that bug_id won't necessarily be defined when this code runs.  This code runs
on DOMContentLoaded, but we fetch the bug_id asynchronously by loading the
details page for the attachment.  I'll land a modified version of this patch
with just the preview button.