[webkit-reviews] review requested: [Bug 46120] RenderImage::intrinsicSizeChanged crashes when m_imageResource is missing : [Attachment 68179] Fix and layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 20 19:53:52 PDT 2010


Cosmin Truta <ctruta at chromium.org> has asked  for review:
Bug 46120: RenderImage::intrinsicSizeChanged crashes when m_imageResource is
missing
https://bugs.webkit.org/show_bug.cgi?id=46120

Attachment 68179: Fix and layout test
https://bugs.webkit.org/attachment.cgi?id=68179&action=review

------- Additional Comments from Cosmin Truta <ctruta at chromium.org>
As I mentioned in the previous comment, perhaps a little ambiguously:
Swapping the order of calls to setStyle/setImageResource inside
RenderObject::createObject and RenderObjectChildList::updateBeforeAfterContent
does not solve the lack of initialization, because initializing a style and
initializing an image resource are cyclically dependent on each other. I am,
therefore, relying on a simple if-check instead, to avoid this issue
altogether.


More information about the webkit-reviews mailing list