[webkit-reviews] review granted: [Bug 46128] webkitpy - display web pages using a common routine : [Attachment 68141] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 20 16:24:20 PDT 2010


Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 46128: webkitpy - display web pages using a common routine
https://bugs.webkit.org/show_bug.cgi?id=46128

Attachment 68141: Patch
https://bugs.webkit.org/attachment.cgi?id=68141&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
LGTM.  It's generally better to use an instance version rather than a static
version of User to make it easier to write unit tests (by injecting a mock user
object as a dependency), but this is a step in the right direction.


More information about the webkit-reviews mailing list