[webkit-reviews] review granted: [Bug 46130] The commit-cluster bots still race to lock patch_ids : [Attachment 68151] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 46130: The commit-cluster bots still race to lock patch_ids
https://bugs.webkit.org/show_bug.cgi?id=46130

Attachment 68151: Patch
https://bugs.webkit.org/attachment.cgi?id=68151&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68151&action=review

> WebKitTools/QueueStatusServer/model/activeworkitems.py:48
> +		   nonexpired_item_ids.append(self.item_ids[i])
> +		   nonexpired_item_dates.append(self.item_dates[i])

I think we should consider hiding these two lists behind a list of tuples
instead.  Then the "API" for dealing with them is to get/set a list of tuples
and their storage is a internal detail of this class (even hidden from the
classes core logic methods).