[webkit-reviews] review granted: [Bug 46126] Add availableLogicalWidth to RenderBox. : [Attachment 68147] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 20 15:31:23 PDT 2010
mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 46126: Add availableLogicalWidth to RenderBox.
https://bugs.webkit.org/show_bug.cgi?id=46126
Attachment 68147: Patch
https://bugs.webkit.org/attachment.cgi?id=68147&action=review
------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=68147&action=review
> WebCore/rendering/RenderBox.cpp:1739
> + if (style()->blockFlow() == TopToBottomBlockFlow || style()->blockFlow()
== BottomToTopBlockFlow)
I think you should start considering RenderStyle::blockFlowAxis() or
RenderStyle::isVerticalBlockFlow() or something.
More information about the webkit-reviews
mailing list