[webkit-reviews] review requested: [Bug 45721] Add a client interface to allow V8Proxy to ask whether an extension should run on a page : [Attachment 68138] try #2, this time with a multi-stage patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 20 14:36:34 PDT 2010


Matt Perry <mpcomplete at chromium.org> has asked	for review:
Bug 45721: Add a client interface to allow V8Proxy to ask whether an extension
should run on a page
https://bugs.webkit.org/show_bug.cgi?id=45721

Attachment 68138: try #2, this time with a multi-stage patch
https://bugs.webkit.org/attachment.cgi?id=68138&action=review

------- Additional Comments from Matt Perry <mpcomplete at chromium.org>
My last patch broke some things and got reverted. I'm going to try to land it
again, in multiple stages this time.

The differences from the previous patch are:
- This is an additive change only. I added a registerExtension2 API that will
be unused until a corresponding Chromium change lands.
- WebFrameClient defaults to allowing all script extensions. I think this is
what broke the previous patch - test_shell and other test clients were probably
preventing important v8 extensions from running.


More information about the webkit-reviews mailing list