[webkit-reviews] review granted: [Bug 40961] REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes : [Attachment 68134] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 40961: REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing
changes
https://bugs.webkit.org/show_bug.cgi?id=40961

Attachment 68134: Patch
https://bugs.webkit.org/attachment.cgi?id=68134&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68134&action=review

> WebCore/html/parser/HTMLDocumentParser.h:145
> +bool usePreHTML5ParserQuirks(Document*);

Generally, we prefer to have these sorts of functions be static methods of a
class:

HTMLDocumentParser::usePreHTML5Quirks(...)

That makes it easier to find the implementation of the function when you see it
called in a random file.

>
LayoutTests/fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-
quoted-state.html:4
> +	   <p></p attr="value"</div>

Can you add a test for <p attr=value</	?