[webkit-reviews] review granted: [Bug 45863] Add HRTFKernel files : [Attachment 67936] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 45863: Add HRTFKernel files
https://bugs.webkit.org/show_bug.cgi?id=45863

Attachment 67936: Patch
https://bugs.webkit.org/attachment.cgi?id=67936&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Looks good! Just some nits, feel free to address while landing or post a new
patch.

View in context:
https://bugs.webkit.org/attachment.cgi?id=67936&action=prettypatch

> WebCore/platform/audio/HRTFKernel.cpp:124
> +    bool checkX = x >= 0.0 && x < 1.0;
> +    ASSERT(checkX);

nit: better to put the predicate directly into the ASSERT()

> WebCore/platform/audio/HRTFKernel.cpp:126
> +    x = max(0.0, x);
> +    x = min(1.0, x);

nit: could be one expression

> WebCore/platform/audio/HRTFKernel.h:67
> +    

nit: extra newline