[webkit-reviews] review granted: [Bug 46028] [FileSystem] Fix Flags handling in DirectoryEntry custom binding code : [Attachment 67997] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 20 13:52:05 PDT 2010


Dumitru Daniliuc <dumi at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 46028: [FileSystem] Fix Flags handling in DirectoryEntry custom binding
code
https://bugs.webkit.org/show_bug.cgi?id=46028

Attachment 67997: Patch
https://bugs.webkit.org/attachment.cgi?id=67997&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
r=me.

toFlags() returns a ref-counted object, because WebCore::Flags is ref-counted,
right? if this is correct, it might be nice to mention this in the ChangeLog
file (to make sure we don't copy-paste this code for some other class, and
automatically assume that toNewClass() will be ref-counted too, when it might
not be).


More information about the webkit-reviews mailing list