[webkit-reviews] review requested: [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text : [Attachment 68105] Single patch for fixing this bug

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 25898: [Gtk] object:text-changed events should be emitted for entries and
password text
https://bugs.webkit.org/show_bug.cgi?id=25898

Attachment 68105: Single patch for fixing this bug
https://bugs.webkit.org/attachment.cgi?id=68105&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #78)
> (From update of attachment 67463 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=67463&action=prettypatch
> 
> > WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:78
> > +	 gchar* detailStr = detail.get();
> > +	 if (detailStr)
> > +	     g_signal_emit_by_name(wrapper, detailStr, offset, count);
> > +}
> 
> This is unnecessary, because GOwnPtr has a implicit bool cast.
> if (detail)
>     g_signal_emit_by_name(wrapper, detail.get(), offset, count);

Fixed

> > WebCore/editing/AppendNodeCommand.cpp:51
> > +	 if (nodeValue != "\n")
> 
> I think this should be an early return.
> 

Done
 
> This look good otherwise, but I'd be more comfortable if someone more
familiar with a11y reviewed the platform-independent parts.

I'm attaching a new patch now, asking for review over it, which I guess should
be pretty straightforward since now it looks now both Chris and Enrica are ok
with the changes in the a11y code and the text editing part, respectively
(Besides, I guess both Eric and you will be ok with the current patch, after
addressing the issues pointed by you two as well)