[webkit-reviews] review granted: [Bug 46079] Fix Opcode stats compilation : [Attachment 68064] opcodestats.diff
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 20 08:41:43 PDT 2010
Martin Robinson <mrobinson at webkit.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 46079: Fix Opcode stats compilation
https://bugs.webkit.org/show_bug.cgi?id=46079
Attachment 68064: opcodestats.diff
https://bugs.webkit.org/attachment.cgi?id=68064&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=68064&action=prettypatch
Looks sane to me!
> JavaScriptCore/bytecode/Opcode.cpp:34
> +#include <stdio.h>
I prefer C++ style includes <cstdio>, but I don't know if this is a WebKit
standard.
More information about the webkit-reviews
mailing list