[webkit-reviews] review denied: [Bug 46090] [chromium] expose the filename used for a given indexed DB : [Attachment 68086] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied jochen at chromium.org's request for
review:
Bug 46090: [chromium] expose the filename used for a given indexed DB
https://bugs.webkit.org/show_bug.cgi?id=46090

Attachment 68086: Patch
https://bugs.webkit.org/attachment.cgi?id=68086&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=68086&action=review

> WebCore/storage/IDBFactoryBackendInterface.cpp:31
> +#include "FileSystem.h"

revert this file

> WebKit/chromium/public/WebIDBFactory.h:68
> +    WEBKIT_API static WebString fileNameForIDB(const WebString& name, const
WebSecurityOrigin& origin);

databaseFileName seems more clear.  Also use that name in WebCore?

> WebKit/chromium/src/WebIDBFactory.cpp:36
> +#if ENABLE(INDEXED_DATABASE)

move this above the #include (the latest style these days)

> WebKit/chromium/src/WebIDBFactory.cpp:42
> +// static

remove comment


Looks close.