[webkit-reviews] review granted: [Bug 46086] Web Inspector: implement pausing on XHR : [Attachment 68079] Proposed patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 46086: Web Inspector: implement pausing on XHR
https://bugs.webkit.org/show_bug.cgi?id=46086

Attachment 68079: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=68079&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
r+ with nits. I'd actually suggest adding one more item into the native
breakpoints list: "Any JavaScript statement" that is On by default. In addition
to that, you change behavior of the Pause button respectively.

View in context: https://bugs.webkit.org/attachment.cgi?id=68079&action=review

> WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp:34
> +#include "InspectorController.h"

Please mind import order.

> WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp:117
> +   
InspectorController::willSendXHR(xmlHttpRequest->scriptExecutionContext(),
xmlHttpRequest->url());

I'd suggest calling it:

InspectorController::instrumentWillSendXmlHttpRequest

And all others will be 'instrument*'.

> WebCore/inspector/Inspector.idl:127
> +	   [handler=Debug] void setPauseOnEventState(in unsigned int eventType,
in boolean state);

pauseOnNextEvent ?