[webkit-reviews] review canceled: [Bug 45416] Allow Chromium port to link with system-provided SQLite : [Attachment 67824] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 20 07:31:18 PDT 2010


Paweł Hajdan, Jr. <phajdan.jr at chromium.org> has canceled Paweł Hajdan, Jr.
<phajdan.jr at chromium.org>'s request for review:
Bug 45416: Allow Chromium port to link with system-provided SQLite
https://bugs.webkit.org/show_bug.cgi?id=45416

Attachment 67824: patch
https://bugs.webkit.org/attachment.cgi?id=67824&action=review

------- Additional Comments from Paweł Hajdan, Jr. <phajdan.jr at chromium.org>
Dumitru, thanks for review. I detected an additional problem with chromiumSync
in previous patch versions (missing dirfd fsync call). I have ported the
original logic more carefully, and tested it on the Mac. Please take another
look.


More information about the webkit-reviews mailing list