[webkit-reviews] review granted: [Bug 45612] SVG Filter cleanup : [Attachment 68072] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 20 07:18:16 PDT 2010
Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 45612: SVG Filter cleanup
https://bugs.webkit.org/show_bug.cgi?id=45612
Attachment 68072: Patch
https://bugs.webkit.org/attachment.cgi?id=68072&action=review
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=68072&action=prettypatch
> WebCore/svg/graphics/filters/SVGFEOffset.cpp:34
> +FEOffset::FEOffset(const float& dx, const float& dy)
s/const float&/float/
> WebCore/svg/graphics/filters/SVGFEOffset.cpp:41
> +PassRefPtr<FEOffset> FEOffset::create(const float& dx, const float& dy)
s/const float&/float/
> WebCore/svg/graphics/filters/SVGFEOffset.h:33
> + static PassRefPtr<FEOffset> create(const float&, const float&);
s/const float&/float/
> WebCore/svg/graphics/filters/SVGFEOffset.h:46
> + FEOffset(const float&, const float&);
s/const float&/float/
Looks good to me with these fixes!
More information about the webkit-reviews
mailing list