[webkit-reviews] review denied: [Bug 46051] SVG: Make RenderPath DRT output platform-independent : [Attachment 68026] Proposed patch, first stab

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 20 04:02:51 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has denied Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 46051: SVG: Make RenderPath DRT output platform-independent
https://bugs.webkit.org/show_bug.cgi?id=46051

Attachment 68026: Proposed patch, first stab
https://bugs.webkit.org/attachment.cgi?id=68026&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Looks good to me!
I'd propose to not add those virtual methods (isRectElement) etc, just for the
sake of DRT.
Just compare the tag names: if (svgElement->hasTagName(SVGNames::rectTag)) {
...}


More information about the webkit-reviews mailing list