[webkit-reviews] review requested: [Bug 44769] [Qt] Web Sockets are insecure with QtWebKit : [Attachment 68025] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 19 08:09:53 PDT 2010


Yael <yael.aharon at nokia.com> has asked	for review:
Bug 44769: [Qt] Web Sockets are insecure with QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=44769

Attachment 68025: Patch.
https://bugs.webkit.org/attachment.cgi?id=68025&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
Throw an error when the websocket server certificate is not valid.
Please note that currently DRT does not test secure websocket connections, so
there is no impact to current layout tests.
Once DRT gets back support for secure websocket connections, this patch will
cause those tests to fail.
If ok with you, let's apply this patch only to webkit 2.1, but not to trunk. I
believe that Chromium is using the same approach.


More information about the webkit-reviews mailing list