[webkit-reviews] review granted: [Bug 42317] Pasteboard doesn't work in WebKit2 : [Attachment 67975] Patch3

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 42317: Pasteboard doesn't work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42317

Attachment 67975: Patch3
https://bugs.webkit.org/attachment.cgi?id=67975&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67975&action=prettypatch

> WebCore/loader/EmptyClients.h:438
> +    virtual DocumentFragment*
documentFragmentFromAttributedString(NSAttributedString*, Vector<
RefPtr<ArchiveResource> >&) { return 0; };

No space before the RefPtr is needed.

> WebCore/page/EditorClient.h:156
> +    virtual DocumentFragment*
documentFragmentFromAttributedString(NSAttributedString*, Vector<
RefPtr<ArchiveResource> >&) = 0;

Here too.

> WebCore/platform/mac/PasteboardMac.mm:410
> +    Vector< RefPtr<ArchiveResource> > resources;

And here.

> WebKit2/WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:84
> +DocumentFragment*
WebEditorClient::documentFragmentFromAttributedString(NSAttributedString
*string, Vector< RefPtr<ArchiveResource> >& resources)
> +{

And here.

> WebKit/mac/WebCoreSupport/WebEditorClient.mm:362
> +DocumentFragment*
WebEditorClient::documentFragmentFromAttributedString(NSAttributedString
*string, Vector< RefPtr<ArchiveResource> >& resources)
>  {

And here,


Otherwise, r=me.