[webkit-reviews] review granted: [Bug 44089] [Qt] Making effective use of Document::nodesFromRect : [Attachment 68010] patch v4 - addressed kenneth's comments (it will fail until bug 44088 is in)

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 44089: [Qt] Making effective use of Document::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=44089

Attachment 68010: patch v4 - addressed kenneth's comments (it will fail until
bug 44088 is in)
https://bugs.webkit.org/attachment.cgi?id=68010&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=68010&action=prettypatch

> WebKit/qt/Api/qwebpage.cpp:1685
> +    // NOTE: The implementation of this method has to be sync'ed with
HitTestResult::regionFromPoint.

Isn't there a way to avoid this? Should it be a FIXME instead?