[webkit-reviews] review denied: [Bug 45984] [Qt] QtWebProcess should clean up shared memory map files on close : [Attachment 68005] proposed patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 45984: [Qt] QtWebProcess should clean up shared memory map files on close
https://bugs.webkit.org/show_bug.cgi?id=45984

Attachment 68005: proposed patch
https://bugs.webkit.org/attachment.cgi?id=68005&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=68005&action=prettypatch

> WebKit2/ChangeLog:14
> +	   * Shared/qt/MappedMemory.cpp: Added.

It seems that you didn't do it correctly, as this was a moved/renamed file. Not
a newly added one.

You need to use git mv or the svn equivalent. r- because of this.