[webkit-reviews] review requested: [Bug 45959] String.prototype.replace passes undefined rather than empty string for groups that don't match : [Attachment 68002] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Sep 18 01:22:33 PDT 2010
Mark Hahnenberg <mhahnenb at gmail.com> has asked for review:
Bug 45959: String.prototype.replace passes undefined rather than empty string
for groups that don't match
https://bugs.webkit.org/show_bug.cgi?id=45959
Attachment 68002: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=68002&action=review
------- Additional Comments from Mark Hahnenberg <mhahnenb at gmail.com>
This seemed like a good starter bug for a new contributor such as myself. I
wasn't sure if I needed to add a regression test and if so, where to put it.
As far as the patch goes, I just replaced the jsUndefined() call with an empty
string retrieved from the JSGlobalData object.
More information about the webkit-reviews
mailing list