[webkit-reviews] review denied: [Bug 46021] Add NoStaticTables attributes to IDLs of FileSystem API for Worker support : [Attachment 67980] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 46021: Add NoStaticTables attributes to IDLs of FileSystem API for Worker
support
https://bugs.webkit.org/show_bug.cgi?id=46021

Attachment 67980: Patch
https://bugs.webkit.org/attachment.cgi?id=67980&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67980&action=prettypatch

Mostly looks good. I had a few question about things that I like to understand
before r+'ing. (If anyone else understands them and wants to r+, that is fine
with me.)

> WebCore/ChangeLog:8
> +	   Also changed their module from storage to fileapi.

Why?

> WebCore/ChangeLog:17
> +	   * fileapi/ErrorCallback.idl:

A few of these idl's including this one didn't get NoStaticTables added to
them. Why? (A ChangeLog comment on these file would be nice to explain it.)