[webkit-reviews] review granted: [Bug 45998] Make certificate data available to the WKFrameRef after it is committed : [Attachment 67952] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 45998: Make certificate data available to the WKFrameRef after it is
committed
https://bugs.webkit.org/show_bug.cgi?id=45998

Attachment 67952: Patch
https://bugs.webkit.org/attachment.cgi?id=67952&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67952&action=prettypatch

Looks good otherwise!

> WebKit2/ChangeLog:18
> +

comma instead of period here (unless you forgot to type something here)

> WebKit2/WebKit2.pro:377
> +    WebProcess/WebCoreSupport/qt/'sQt.cpp \

This looks wrong :)

> WebKit2/Shared/APIObject.h:37
> +	   TypeNull = 0,

No need for this.

> WebKit2/Shared/WebCertificateInfo.h:45
> +    void setPlatformCertificateInfo(const PlatformCertificateInfo& info) {
m_platformCertificateInfo = info; }

Maybe we should make WebCertificatInfo immutable and just replace the entire
object instead?

> WebKit2/Shared/mac/PlatformCertificateInfo.h:51
> +

Please put this inside #ifndef NDEBUG

> WebKit2/Shared/mac/PlatformCertificateInfo.mm:47
> +{

Same here.

> WebKit2/Shared/mac/PlatformCertificateInfo.mm:61
> +	   encoder->encodeBool(false);

I think you can use a numeric_limits<uint64>::max() to indicate an empty list
instead (that's what we do for strings).

> WebKit2/Shared/mac/PlatformCertificateInfo.mm:77
> +    printf("PlatformCertificateInfo::encode Total Size %d", (int)totalSize);


Remove this.

> WebKit2/Shared/qt/PlatformCertificateInfo.h:41
> +    PlatformCertificateInfo(const WebCore::ResourceResponse&)

Make this constructor explicit.

> WebKit2/Shared/win/PlatformCertificateInfo.h:41
> +    PlatformCertificateInfo(const WebCore::ResourceResponse&)

Make this constructor explicit.

> WebKit2/UIProcess/WebFrameProxy.cpp:41
> +    , m_certificateInfo(WebCertificateInfo::create())

Could we initialize this lazily?

> WebKit2/UIProcess/WebFrameProxy.h:77
> +    void setPlatformCertificateInfo(const PlatformCertificateInfo&);

I think it would be better if setPlatformCertificatInfo actually took a
PassRefPtr<WebCertificateInfo>