[webkit-reviews] review granted: [Bug 45942] [GTK] fast/forms/listbox-selection.html fails : [Attachment 67877] Patch for this issue

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 45942: [GTK] fast/forms/listbox-selection.html fails
https://bugs.webkit.org/show_bug.cgi?id=45942

Attachment 67877: Patch for this issue
https://bugs.webkit.org/attachment.cgi?id=67877&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67877&action=prettypatch

This patch looks sane to me.

r=me

> LayoutTests/platform/gtk/Skipped:-1169
> -fast/forms/listbox-selection.html

I did a brief search for all layout tests that call eventSender.keyDown() with
a non-empty list of modifiers that are also in the GTK Skipped list and found
fast/events/keydown-1.html. Does this still fail?

> WebKitTools/DumpRenderTree/gtk/EventSender.cpp:463
> +    // Get the modifiers from the second argument.
> +    guint modifiers = argumentCount >= 2 ? gdkModifersFromJSValue(context,
arguments[1]) : 0;

I noticed that you did not put a similar comment "// Get the modifiers from the
second argument." above the other call sites in mouseUpCallback and
mouseDownCallback. We may want to consider putting such a comment at these
other call sites.