[webkit-reviews] review granted: [Bug 45880] createBlobURL with no argument causes crash : [Attachment 67926] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 17 11:45:52 PDT 2010


Dmitry Titov <dimich at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 45880: createBlobURL with no argument causes crash
https://bugs.webkit.org/show_bug.cgi?id=45880

Attachment 67926: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=67926&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
r+ with 2 nits

View in context:
https://bugs.webkit.org/attachment.cgi?id=67926&action=prettypatch

> LayoutTests/fast/files/create-blob-url-crash.html:3
> +<body>

I think by moving 'script' tag before the body and just setting the <body
onload="test()"> it's possible to get rid of need to use notifyDone().

> LayoutTests/fast/files/create-blob-url-crash.html:23
> +if (window.eventSender) {

you don't use eventSender, so the check could be just "if
(window.layoutTestController) ..."


More information about the webkit-reviews mailing list