[webkit-reviews] review requested: [Bug 45787] Yarr JIT code checks BOL (^) each time through loop when in subexpression : [Attachment 67924] Patch with changes recommended by reviewer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 17 11:18:18 PDT 2010


Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 45787: Yarr JIT code checks BOL (^) each time through loop when in
subexpression
https://bugs.webkit.org/show_bug.cgi?id=45787

Attachment 67924: Patch with changes recommended by reviewer
https://bugs.webkit.org/attachment.cgi?id=67924&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
Cleaned up both style issues pointed out.

Added code to properly handle expressions like /^a/ to only execute once and
never loop.

Found and fixed issue for expressions like /(?!^)a/ which should not be marked
as starting with a BOL, since they start with NOT BOL!


More information about the webkit-reviews mailing list