[webkit-reviews] review canceled: [Bug 45970] Add StringHasher class : [Attachment 67916] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 17 10:55:48 PDT 2010


Patrick R. Gansterer <paroga at paroga.com> has canceled Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 45970: Add StringHasher class
https://bugs.webkit.org/show_bug.cgi?id=45970

Attachment 67916: Patch
https://bugs.webkit.org/attachment.cgi?id=67916&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
(In reply to comment #2)
> Changing this will almost certainly break JavaScriptCore, which uses the high
bit for something else. Please talk to Gavin Barraclough about this.
http://trac.webkit.org/changeset/53456: I don't know what "it causes much
sadness in this world" means exactly ;-)
http://trac.webkit.org/changeset/52856: "change string hash result from 32-bit
to 31-bit, to free a bit in UStringImpl for m_isIdentifier"

I changed it to use only 31 bits and added a comment.


More information about the webkit-reviews mailing list