[webkit-reviews] review requested: [Bug 45383] [Gtk] Incorrect exposure of list items whose children are elements : [Attachment 67918] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 45383: [Gtk] Incorrect exposure of list items whose children are elements
https://bugs.webkit.org/show_bug.cgi?id=45383

Attachment 67918: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=67918&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
After some work I think the most simple way to fix this is by just forcing
inclusion in accessibility of the list items in the platform-dependant part of
the accessibilityIsIgnored() mechanism, as I found the behaviour of not
exposing the list item when its immediate child is a non inline object is the
expected behaviour, as coded in
AccessibilityRenderObject::accessibilityIsIgnored():

    [...]
	
    if (m_renderer->isBlockFlow() && m_renderer->childrenInline())
	return !toRenderBlock(m_renderer)->firstLineBox() &&
!mouseButtonListener();
    
    [...]

As that part of code is what it's making the difference between a <li>plain
text</li> item and a <li><p>paragraph text</p></li> item, I thought the best
way to fix this for GTK without bothering other ports was the exposed above.

Then there's an ugly part in the patch that is required to deal with the
special case of the list item markers, which are not exposed to AT's but must
be taken into account anyway when considering offets and those kind of things.

Hence, now asking for review. Shoot your questions, I'm eager to continue
working on this patch.