[webkit-reviews] review granted: [Bug 45960] WK2: REGRESSION (r66156): Web sites using AppleConnect fail to log in: "HTTP Status 404 - /ssowebapp/scriptFrame" : [Attachment 67906] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 45960: WK2: REGRESSION (r66156): Web sites using AppleConnect fail to log
in: "HTTP Status 404 - /ssowebapp/scriptFrame"
https://bugs.webkit.org/show_bug.cgi?id=45960

Attachment 67906: Patch
https://bugs.webkit.org/attachment.cgi?id=67906&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>      Plugin::Parameters parameters;
>      parameters.url = url;
> -    parameters.names = paramNames;
>      parameters.values = paramValues;
>      parameters.mimeType = mimeType;
>      parameters.loadManually = loadManually;
> +    
> +    // <rdar://problem/8440903>: AppleConnect has a bug where it does not
> +    // understand the parameter names specified in the <object> element that

> +    // embeds its plug-in. This hack works around the issue by converting
the
> +    // parameter names to lowercase before passing them to the plug-in.
> +    if (equalIgnoringCase(mimeType, "application/x-snkp")) {
> +	   parameters.names.reserveCapacity(paramNames.size());
> +	   for (size_t i = 0; i < paramNames.size(); ++i)
> +	       parameters.names.append(paramNames[i].lower());
> +    } else
> +	   parameters.names = paramNames;

Why not leave the line of code above alone, and write the new code as a
removable block. That seems to isolate the AppleConnect workaround a little
better from the non-workaround code.

r=me