[webkit-reviews] review granted: [Bug 45789] WebKit should use system wide spell checking preference when application specific one isn't set. : [Attachment 67884] Proposed patch (v4)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 17 00:14:23 PDT 2010


mitz at webkit.org has granted jpu at apple.com's request for review:
Bug 45789: WebKit should use system wide spell checking preference when
application specific one isn't set.
https://bugs.webkit.org/show_bug.cgi?id=45789

Attachment 67884: Proposed patch (v4)
https://bugs.webkit.org/attachment.cgi?id=67884&action=review

------- Additional Comments from mitz at webkit.org
View in context:
https://bugs.webkit.org/attachment.cgi?id=67884&action=prettypatch

> WebKit/mac/WebView/WebView.mm:109
> +#if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD) &&
!defined(BUILDING_ON_SNOW_LEOPARD)
> +#import <AppKit/NSTextChecker.h>
> +#endif

When an #import or #include directive is in an #if block, that block usually
appears as a separate paragraph after the main #import paragraph. I will make
this change when I land the patch.


More information about the webkit-reviews mailing list