[webkit-reviews] review granted: [Bug 45938] _web_makePluginViewsPerformSelector:: mutates subviews array while iterating it : [Attachment 67870] Patch to avoid mutating array while enumerating it.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 16 19:40:46 PDT 2010


Darin Adler <darin at apple.com> has granted John Sullivan <sullivan at apple.com>'s
request for review:
Bug 45938: _web_makePluginViewsPerformSelector:: mutates subviews array while
iterating it
https://bugs.webkit.org/show_bug.cgi?id=45938

Attachment 67870: Patch to avoid mutating array while enumerating it.
https://bugs.webkit.org/attachment.cgi?id=67870&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Historically, objectEnumerator creating a copy of the entire array! I’m
surprised that it has changed so that it no longer does so.

Does this work properly when there are no subviews?

Instead of initWithArray: you could have used the copy method.

r=me


More information about the webkit-reviews mailing list