[webkit-reviews] review requested: [Bug 45787] Yarr JIT code checks BOL (^) each time through loop when in subexpression : [Attachment 67868] Patch that handles broader class of ^ anchored expressions.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 16 17:51:48 PDT 2010
Michael Saboff <msaboff at apple.com> has asked for review:
Bug 45787: Yarr JIT code checks BOL (^) each time through loop when in
subexpression
https://bugs.webkit.org/show_bug.cgi?id=45787
Attachment 67868: Patch that handles broader class of ^ anchored expressions.
https://bugs.webkit.org/attachment.cgi?id=67868&action=review
------- Additional Comments from Michael Saboff <msaboff at apple.com>
This patch unrolls expressions with any alternative that contains ^ anchoring.
Compared to the prior patch, this patch uses the parse to record expressions
that are BOL anchored. The routine optimizeBOL() then re-factors the
expression,
adding alternatives that don't contain BOL anchoring. The original expression
is
executed once and the alternatives without BOL anchoring are looped over.
More information about the webkit-reviews
mailing list