[webkit-reviews] review requested: [Bug 45831] [Qt] Turn on PLATFORM_STRATEGIES : [Attachment 67833] Initial patch

[bugzilla-daemon at webkit.org]

Ademar Reis <ademar.reis at openbossa.org> has asked  for review:
Bug 45831: [Qt] Turn on PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=45831

Attachment 67833: Initial patch
https://bugs.webkit.org/attachment.cgi?id=67833&action=review

------- Additional Comments from Ademar Reis <ademar.reis at openbossa.org>
Initial patch for review.

Question for review: Inside our localization implementation, the following
methods were inside an #if ENABLE(VIDEO):

localizedMediaControlElementString()
localizedMediaControlElementHelpText()
localizedMediaTimeDescription()
(these methods are relatively large, ~40 strings total)

But the WebCore::LocalizationStrategy base-class (pure virtual) doesn't have
such conditional.

In my patch I added an #else and implemented stubs for these methods in case
VIDEO is disabled. Should I add #if ENABLE(VIDEO) in the base class instead
(and change the other ports as well)?