[webkit-reviews] review denied: [Bug 45887] Web Inspector: move resourceTracking flag under control of BackendSettings : [Attachment 67794] [patch] initial version.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 16 12:30:58 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 45887: Web Inspector: move resourceTracking flag under control of
BackendSettings
https://bugs.webkit.org/show_bug.cgi?id=45887

Attachment 67794: [patch] initial version.
https://bugs.webkit.org/attachment.cgi?id=67794&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67794&action=prettypatch

> WebCore/inspector/InspectorController.cpp:1102
> +void InspectorController::setResourceTracking(bool enable, bool always,
bool* newState)

setResourceTrackingEnabled

> WebCore/inspector/InspectorController.h:173
> +    void setResourceTracking(bool enable);

setResourceTrackingEnabled

> WebCore/inspector/front-end/ResourcesPanel.js:758
> +		   WebInspector.panels.resources.resourceTrackingWasEnabled();

No need to access this via WebInspector.panels.resources. Just bing the
function.

> WebCore/inspector/front-end/Settings.js:90
> +	   if (settings.resourceTrackingEnabled)

Settings should not be resources aware. I'd r- for this.


More information about the webkit-reviews mailing list