[webkit-reviews] review granted: [Bug 45914] [chromium] Expose separate GraphicsContext3DInternal.h : [Attachment 67827] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 16 12:18:49 PDT 2010
James Robinson <jamesr at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 45914: [chromium] Expose separate GraphicsContext3DInternal.h
https://bugs.webkit.org/show_bug.cgi?id=45914
Attachment 67827: Patch
https://bugs.webkit.org/attachment.cgi?id=67827&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67827&action=prettypatch
R=me
> WebKit/chromium/src/GraphicsContext3DInternal.h:51
> + bool initialize(GraphicsContext3D::Attributes attrs, HostWindow*
hostWindow);
nit: don't name these params
> WebKit/chromium/src/GraphicsContext3DInternal.h:62
> + void paintRenderingResultsToCanvas(CanvasRenderingContext* context);
nit: don't name param
More information about the webkit-reviews
mailing list